adam
/
darkice
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Clean the Util::strToL() number conversion, add proper error check and reporting, possible fix for issue #19

This commit is contained in:
oetelaar.automatisering@gmail.com 2013-05-16 09:45:16 +00:00
parent 00623f1ebc
commit 8bee03c4ab
2 changed files with 22 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
darkice/trunk/src/Util.cpp
View File

@ -33,6 +33,12 @@
#include "config.h"
#endif
#ifdef HAVE_ERRNO_H
#include <errno.h>
#else
#error need errno.h
#endif
#ifdef HAVE_STRING_H
#include <string.h>
#else
@ -245,20 +251,22 @@ Util :: strEq( const char * str1,
* Convert a string to a long integer
*----------------------------------------------------------------------------*/
long int
Util :: strToL( const char * str,
int base ) throw ( Exception )
Util :: strToL( const char *str) throw ( Exception )
{
long int val;
char * s;
char *end;
if ( !str ) {
throw Exception( __FILE__, __LINE__, "no str");
}
if ( NULL == str )
throw Exception( __FILE__, __LINE__, "null pointer parameter, not string");
val = strtol( str, &s, base);
if ( s == str || val == LONG_MIN || val == LONG_MAX ) {
throw Exception( __FILE__, __LINE__, "number conversion error");
}
errno = 0; // set it, strtol() can change it
val = strtol( str, &end, 10);
if (end == str)
throw Exception( __FILE__, __LINE__, "number conversion error, not a decimal string");
if ((LONG_MIN == val || LONG_MAX == val) && ERANGE == errno)
throw Exception( __FILE__, __LINE__, "number conversion error, out of range of type long");
return val;
}

4
darkice/trunk/src/Util.h
View File

@ -187,13 +187,11 @@ class Util
* Convert a string to long.
*
* @param str the string to convert.
* @param base numeric base of number in str.
* @return the value of str as a long int
* @exception Exception
*/
static long int
strToL ( const char * str,
int base = 10 ) throw ( Exception );
strToL ( const char * str) throw ( Exception );
/**
* Convert a string to double.