From 97d40814996914aa3f1e5082db48049104e64e9b Mon Sep 17 00:00:00 2001 From: darkeye Date: Fri, 29 Nov 2002 08:14:47 +0000 Subject: [PATCH] fixed minor bug in IcecCast2.cpp, which could have lead to a buffer overflow --- darkice/trunk/AUTHORS | 1 + darkice/trunk/ChangeLog | 2 ++ darkice/trunk/src/IceCast2.cpp | 6 +++++- 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/darkice/trunk/AUTHORS b/darkice/trunk/AUTHORS index 047afde..07fcc56 100644 --- a/darkice/trunk/AUTHORS +++ b/darkice/trunk/AUTHORS @@ -14,4 +14,5 @@ with contributions by: Kristjan G. Bjarnason Nicu Pavel Kai Krakow + Atsuhiko Yamanaka diff --git a/darkice/trunk/ChangeLog b/darkice/trunk/ChangeLog index a955ae3..bb2312b 100644 --- a/darkice/trunk/ChangeLog +++ b/darkice/trunk/ChangeLog @@ -1,5 +1,7 @@ DarkIce next version: + o bugfix: fixed minor bug in IcecCast2.cpp, which could have lead to + a buffer overflow. thanks to Atsuhiko Yamanaka o bugfix: MultiThreadedConnector::sinkThread() was private, now public o added fileAddDate configuration option thanks to Nicu Pavel diff --git a/darkice/trunk/src/IceCast2.cpp b/darkice/trunk/src/IceCast2.cpp index fe5fb7b..f62fc04 100644 --- a/darkice/trunk/src/IceCast2.cpp +++ b/darkice/trunk/src/IceCast2.cpp @@ -171,7 +171,7 @@ IceCast2 :: sendLogin ( void ) throw ( Exception ) char * source = "source:"; const char * pwd = getPassword(); char * tmp = new char[Util::strLen(source) + - Util::strLen(str) + 1]; + Util::strLen(pwd) + 1]; Util::strCpy( tmp, source); Util::strCat( tmp, pwd); char * base64 = Util::base64Encode( tmp); @@ -255,6 +255,10 @@ IceCast2 :: sendLogin ( void ) throw ( Exception ) $Source$ $Log$ + Revision 1.10 2002/11/29 08:14:47 darkeye + fixed minor bug in IcecCast2.cpp, which could have lead to a buffer + overflow + Revision 1.9 2002/10/20 21:09:35 darkeye added processing of server response